[PATCH weston 2/2] libweston: fix output reflow on removal

Pekka Paalanen ppaalanen at gmail.com
Thu Jun 21 12:53:18 UTC 2018


From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>

This is regression apparently introduced in
0de859ede4bad72b5d3b78e086632f02196d997f, which accidentally swapped the
sign of 'delta_width' in the original call site. If one removes an
output, the remaining outputs on the right are getting moved even
further to the right.

The outputs to the right should be moved to the left instead, to close
the gap left by the removed output.

Reported-by: Tomasz Olszak <olszak.tomasz at gmail.com>
Signed-off-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
---
 libweston/compositor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libweston/compositor.c b/libweston/compositor.c
index 8e01eacc..516be96b 100644
--- a/libweston/compositor.c
+++ b/libweston/compositor.c
@@ -5409,7 +5409,7 @@ weston_compositor_remove_output(struct weston_output *output)
 
 	weston_presentation_feedback_discard_list(&output->feedback_list);
 
-	weston_compositor_reflow_outputs(compositor, output, output->width);
+	weston_compositor_reflow_outputs(compositor, output, -output->width);
 
 	wl_list_remove(&output->link);
 	wl_list_insert(compositor->pending_output_list.prev, &output->link);
-- 
2.16.4



More information about the wayland-devel mailing list