[PATCH 0/5] Implement support for drm properties "GAMMA_LUT" and "CTM"

[Matheus Santana]

Hi Harsha,

Weston needs to be rebuilt. But, no new library versions dependencies.


All right.

On Mon, Jun 25, 2018 at 10:21 AM, Harsha Manjula Mallikarjun (RBEI/ECF3) <
Harsha.ManjulaMallikarjun at in.bosch.com> wrote:

> Hi Matheus,
>
> >From: Matheus Santana [mailto:embs at cin.ufpe.br]
> >Sent: Friday, June 22, 2018 8:33 PM
> >To: Harsha Manjula Mallikarjun (RBEI/ECF3) <Harsha.ManjulaMallikarjun at in.
> bosch.com>
> >Cc: wayland-devel at lists.freedesktop.org
> >Subject: Re: [PATCH 0/5] Implement support for drm properties "GAMMA_LUT"
> and "CTM"
> >
> >Hi Harsha,
> >I am unable to run the tests you introduced. Tests execution gets stuck
> after reporting success for surface-global-test.
>
> Surface-global-test terminates the compositor. May be this is the reason.
> I do not see a stuck test rather a terminated compositor.
>
> For testing I modified Weston.ini as follows:
> modules=ivi-controller.so, surface-global-test.so,gamma-
> test.so,ctm-test.so
>
> Are you running tests in an another way?
>

I'm running them by just issuing `make check` after building weston. I
basically execute three commands (within weston's root dir):

    $ ./autogen.sh --prefix=$WLD
    $ make
    $ make check

The output for `autogen.sh` (which is the same regardless patches
application) is attached.
All tests in suite run fine (24 passed, 1 skipped) when running these
commands without the paches.

I'm applying the patches by downloading the mbox and `git am patches.mbox`.

Are you able to run all tests in suite by just `make check` after building
the project?


Best regards,
Matheus

P.S.: it shouldn't make a difference but I've applied the new version you
provided and tried it again without luck.


>
> >Is it necessary building weston against any newer libraries versions for
> running the new tests?
> >
> >Thanks,
> >Matheus
> >
> >On Fri, Jun 22, 2018 at 10:23 AM, <harsha.manjulamallikarjun at in.bosch.com>
> wrote:
> >From: Harsha M M <harsha.manjulamallikarjun at in.bosch.com>
> >
> >current drm backend uses drmModeCrtcSetGamma to set the gamma look up
> table.
> >This api is a legacy now. DRM backend should support setting of gamma
> look up
> >table through GAMMA_LUT property to keep up with the latest DRM.
> >
> >DRM has support for setting color transformation matrix. This is useful
> for
> >tuning additional display settings like brightness, saturation and hue.
> >
> >This patch series adds support for setting of these two drm properties
> along
> >with respective tests.
> >
> >Harsha M M (5):
> >  compositor-drm: Implement support for GAMMA_LUT drm property
> >  libweston: provide support to set color transformation matrix for
> >    output
> >  compositor-drm: add support for CTM property
> >  tests: add test for setting gamma
> >  tests: add test for color transformation matrix
> >
> > Makefile.am                |  13 ++-
> > libweston/compositor-drm.c | 149 +++++++++++++++++++++++++--
> > libweston/compositor.h     |  12 +++
> > tests/ctm-test.c           | 210 ++++++++++++++++++++++++++++++++++++++
> > tests/gamma-test.c         | 248 ++++++++++++++++++++++++++++++
> +++++++++++++++
> > 5 files changed, 625 insertions(+), 7 deletions(-)
> > create mode 100644 tests/ctm-test.c
> > create mode 100644 tests/gamma-test.c
> >
> >--
> >2.7.4
> >
> >_______________________________________________
> >wayland-devel mailing list
> >wayland-devel at lists.freedesktop.org
> >https://lists.freedesktop.org/mailman/listinfo/wayland-devel
>
> Best regards,
> Harsha MM
> RBEI/ECF3
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20180625/824cfb49/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: autogen-with-patches.log
Type: text/x-log
Size: 8968 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20180625/824cfb49/attachment-0001.bin>