[PATCH 0/5] Implement support for drm properties "GAMMA_LUT" and "CTM"

[Emil Velikov]

On 26 June 2018 at 17:47, Matheus Santana <embs at cin.ufpe.br> wrote:
>
>
> On Tue, Jun 26, 2018 at 11:51 AM, Emil Velikov <emil.l.velikov at gmail.com>
> wrote:
>>
>> On 25 June 2018 at 19:48, Matheus Santana <embs at cin.ufpe.br> wrote:
>> > Hi Harsha,
>> >
>> >> Weston needs to be rebuilt. But, no new library versions dependencies.
>> >
>> >
>> > All right.
>> >
>> > On Mon, Jun 25, 2018 at 10:21 AM, Harsha Manjula Mallikarjun (RBEI/ECF3)
>> > <Harsha.ManjulaMallikarjun at in.bosch.com> wrote:
>> >>
>> >> Hi Matheus,
>> >>
>> >> >From: Matheus Santana [mailto:embs at cin.ufpe.br]
>> >> >Sent: Friday, June 22, 2018 8:33 PM
>> >> >To: Harsha Manjula Mallikarjun (RBEI/ECF3)
>> >> > <Harsha.ManjulaMallikarjun at in.bosch.com>
>> >> >Cc: wayland-devel at lists.freedesktop.org
>> >> >Subject: Re: [PATCH 0/5] Implement support for drm properties
>> >> > "GAMMA_LUT"
>> >> > and "CTM"
>> >> >
>> >> >Hi Harsha,
>> >> >I am unable to run the tests you introduced. Tests execution gets
>> >> > stuck
>> >> > after reporting success for surface-global-test.
>> >>
>> >> Surface-global-test terminates the compositor. May be this is the
>> >> reason.
>> >> I do not see a stuck test rather a terminated compositor.
>> >>
>> >> For testing I modified Weston.ini as follows:
>> >> modules=ivi-controller.so,
>> >> surface-global-test.so,gamma-test.so,ctm-test.so
>> >>
>> >> Are you running tests in an another way?
>> >
>> >
>> > I'm running them by just issuing `make check` after building weston. I
>> > basically execute three commands (within weston's root dir):
>> >
>> >     $ ./autogen.sh --prefix=$WLD
>> >     $ make
>> >     $ make check
>> >
>> > The output for `autogen.sh` (which is the same regardless patches
>> > application) is attached.
>> > All tests in suite run fine (24 passed, 1 skipped) when running these
>> > commands without the paches.
>> >
>> > I'm applying the patches by downloading the mbox and `git am
>> > patches.mbox`.
>> >
>> > Are you able to run all tests in suite by just `make check` after
>> > building
>> > the project?
>> >
>> Matheus your assumption is correct. make check should pass, without
>> any local changes.
>>
>> Quick look points the following:
>>  - the drm (compositor-drm) backend supports the new functionality
>>  - the default backend (see tests/weston-tests-env) is headless
>> (compositor-headless)
>
>
> So we shouldn't run drm-specific tests with `make check`, maybe?
>
Personally I would try some of the following:
 a) see if a test specific ini file (see [0] and draw inspiration from
existing ini files) won't help
 b) enhance the testing infra to allow selecting the backend

Then again, might be better to see what more experienced developers prefer.

>>
>>  - xwayland is used - not sure if the xwayland codebase (which lives
>> in the Xserver repo) needs updates
>
>
> Would you please point out what does indicate that xwayland is in use?
>
This line [1] says "all tests with .la extension, will be run via
weston-tests-env". While this hunk [2] does the execution and you can
--xwayland in there.

HTH
Emil

[0] https://gitlab.freedesktop.org/wayland/weston/blob/78a42116ae92f93a01539a785ce95cc478189608/tests/weston-tests-env#L41
[1] https://gitlab.freedesktop.org/wayland/weston/blob/78a42116ae92f93a01539a785ce95cc478189608/Makefile.am#L1264
[2] https://gitlab.freedesktop.org/wayland/weston/blob/78a42116ae92f93a01539a785ce95cc478189608/tests/weston-tests-env#L67