[PATCH] compositor-wayland: Ignore pointer enter on destroyed surface

[Daniel Stone]

Hi,

On 9 March 2018 at 14:08, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> On Fri,  9 Mar 2018 10:08:37 +0000
> Daniel Stone <daniels at collabora.com> wrote:
>> +     if (!surface) {
>> +             input->output = NULL;
>> +             input->has_focus = false;
>> +             notify_pointer_focus(&input->base, NULL, 0, 0);
>> +             input_set_cursor(input);
>> +             return;
>> +     }
>> +
>>       x = wl_fixed_to_double(fixed_x);
>>       y = wl_fixed_to_double(fixed_y);
>>
>
> Hi Daniel,
>
> looks good, but what is the input_set_cursor() call doing there?

Pure cargo-cult from the bottom of the function here. I guess it's
probably unlikely to be helpful: if we've already destroyed the
surface, there's little to no point setting a cursor on it. So I think
it can, in fact, be removed.

Cheers,
Daniel