[PATCH weston 1/2] clients: consolidate timer code part 1

[Pekka Paalanen]

On Fri, 9 Mar 2018 11:32:47 -0600
Derek Foreman <derekf at osg.samsung.com> wrote:

> On 2018-03-09 05:44 AM, Pekka Paalanen wrote:
> > From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> > 
> > There are multiple copies for the timerfd handling code, and I need a
> > timer in one more app. Consolidate all the timerfd code into window.c to
> > reduce the duplication. Many of the copies were also flawed against the
> > race mentioned in toytimer_fire().
> > 
> > This patch handles clickdot and window.c's tooltip timer and cursor
> > timer.
> > 
> > Signed-off-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>  
> 
> Just out of curiosity, how'd you decide to break it down this way?

Mind flow. First I thought of doing just one patch, but it started to
look a bit big, the window.c parts particularly. No rationale behind
the split, for once. :-)

> Both patches look good to me.  I hate that reset/fire race and wasted a 
> bit of time understanding it the first time I hit it.  I'm really happy 
> to see it handled consistently in one place.
> 
> Reviewed-by: Derek Foreman <derekf at osg.samsung.com>
> For both.

Thank you.

> I think they look safe to land now, as it's mostly harmless refactor, 
> and the rest is actual bug fix, as abort()ing on the read fail was wrong.
> 
> I'll let you make the call on landing it. :)

Thank you to Daniel as well for the comments, pushed:
   3f839374..64a26bc1  master -> master


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20180312/b3361e78/attachment.sig>