[PATCH weston] build: honour libinput header location

Pekka Paalanen ppaalanen at gmail.com
Thu Mar 15 12:20:25 UTC 2018


On Tue, 27 Feb 2018 14:14:27 +0000
Emil Velikov <emil.l.velikov at gmail.com> wrote:

> From: Jan Engelhardt <jengelh at inai.de>
> 
> Add the respective CFLAGS to the build, otherwise the build will error
> out as seen below.
> 
> src/libinput-seat.c:30:22: fatal error: libinput.h: No such file or directory
> 
> [Emil Velikov: polish commit message]
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
> Jan, don't be shy to send patches upstream. Devs. won't bite... most of
> the time ;-)
> ---
>  Makefile.am | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Makefile.am b/Makefile.am
> index b5c29c04..8de40e51 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -43,7 +43,8 @@ AM_CPPFLAGS = 					\
>  	-I$(top_builddir)/protocol		\
>  	-DLIBWESTON_MODULEDIR='"$(libweston_moduledir)"' \
>  	-DLIBEXECDIR='"$(libexecdir)"'		\
> -	-DBINDIR='"$(bindir)"'
> +	-DBINDIR='"$(bindir)"' \
> +	$(LIBINPUT_BACKEND_CFLAGS)
>  
>  CLEANFILES = weston.ini				\
>  	ivi-shell/weston.ini			\

Hi,

I don't think we want the libinput flags on *everything*, but in the
same places where LIBINPUT_BACKEND_LIBS are already used.

Or do you think we should actually have CFLAGS of all deps with
everything we build, and just gate the LIBS we link with to the targets
that actually need it?


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20180315/d4f4207b/attachment.sig>


More information about the wayland-devel mailing list