[PATCH wayland v3 1/3] wayland-egl: fail the symbol check if lib is missing

Emil Velikov emil.l.velikov at gmail.com
Thu Mar 15 14:30:27 UTC 2018


From: Emil Velikov <emil.velikov at collabora.com>

Based on a similar patch (in Mesa) by Eric Engestrom.

v2: Rebase on top of $NM patch
v3: Rebase

Reviewed-by: Eric Engestrom <eric at engestrom.ch> (v1)
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
---
 egl/wayland-egl-symbols-check | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/egl/wayland-egl-symbols-check b/egl/wayland-egl-symbols-check
index 6ad28f3..8b3d711 100755
--- a/egl/wayland-egl-symbols-check
+++ b/egl/wayland-egl-symbols-check
@@ -1,6 +1,14 @@
 #!/bin/sh
+set -eu
 
-FUNCS=$($NM -D --defined-only ${WAYLAND_EGL_LIB} | grep -o "T .*" | cut -c 3- | while read func; do
+LIB=${WAYLAND_EGL_LIB}
+
+if [ ! -f "$LIB" ]; then
+	echo "The test binary \"$LIB\" does no exist"
+	exit 1
+fi
+
+FUNCS=$($NM -D --defined-only $LIB | grep -o "T .*" | cut -c 3- | while read func; do
 ( grep -q "^$func$" || echo $func )  <<EOF
 wl_egl_window_resize
 wl_egl_window_create
-- 
2.16.0



More information about the wayland-devel mailing list