[PATCH weston 0/3] Allow simple-dmabuf-drm to pass y_inverted flag and cleanups

Guido Günther agx at sigxcpu.org
Mon Mar 19 10:32:50 UTC 2018


On Mon, Mar 19, 2018 at 12:12:36PM +0200, Pekka Paalanen wrote:
> On Fri, 16 Mar 2018 18:56:47 +0100
> Guido Günther <agx at sigxcpu.org> wrote:
> 
> > Changes from v2
> > 
> >  - Explain OPT_* usage
> >  - Switch is_immediate to OPT_*
> >  - use getopt_long
> > 
> > Changes from v1
> > 
> >  - introduce opts as a bitmask of features that can be used to
> >    manipulate the displayed image
> > 
> > Guido Günther (3):
> >   Allow simple-dmabuf-drm to pass y_inverted flag
> >   simple-dmabuf-drm: use opt bitmask instead of is_immediate
> >   simple-dmabuf-drm: use getopt_long
> > 
> >  clients/simple-dmabuf-drm.c | 76 ++++++++++++++++++++++++++++-----------------
> >  1 file changed, 47 insertions(+), 29 deletions(-)
> > 
> 
> Hi,
> 
> all three pushed:
>    63fcad48..60970ec2  master -> master


> For review, it would have been easier to convert to getopt_long first
> and then add new options, to avoid reviewing code that gets removed
> immediately after.

Thanks a lot for your review!
 -- Guido


More information about the wayland-devel mailing list