[PATCH wayland v3 1/3] wayland-egl: fail the symbol check if lib is missing

[Daniel Stone]

Hi,

On 19 March 2018 at 11:43, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 19 March 2018 at 09:56, Pekka Paalanen <ppaalanen at gmail.com> wrote:
>> On Fri, 16 Mar 2018 16:18:57 +0000
>> Emil Velikov <emil.l.velikov at gmail.com> wrote:
>>> Right - I was aiming to remove the bonkers envvar and forgot about
>>> this preexisting bug.
>>> Patch (to be applied before the series) coming in a second.
>>
>> In egl/wayland-egl-symbols-check.log I have:
>>
>> ./egl/wayland-egl-symbols-check: line 11: NM: unbound variable
>>
> Seems like a 'fun' side-effect of the $NM patch. The series predates
> the patch by a week.
> First suggestion that comes to mind - use $(NM-nm}
>
> Eric any suggestions?

The root cause is that NM is only ever set as a make variable (by
AC_PROG_NM); it's never actually added to the shell-based test
environment.

Thanks for catching this, Pekka - I just noted that the tests
succeeded, and didn't think to check the failure conditions. :\ I've
sent out two patches now, one fixing NM and one fixing the failure to
fail.

Cheers,
Daniel