[PATCH wayland] wayland-egl: Make symbol test fail on failure

[Emil Velikov]

On 19 March 2018 at 15:13, Daniel Stone <daniels at collabora.com> wrote:
> The previous rewrite of the wayland-egl ABI checker introduced checks
> for removed symbols as well as added symbols, but broke some failure
> conditions. Add an explict return-code variable set in failure paths,
> rather than chaining or conditions.
>
> If we cannot find the binary or nm, we regard this as an error
> condition, rather than test failure.
>
> v2: Don't test if we can execute $NM.
>
> Signed-off-by: Daniel Stone <daniels at collabora.com>
> Reported-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> Fixes: 21b1f22eb056 ("wayland-egl: enhance the symbol test")
> Cc: Emil Velikov <emil.velikov at collabora.com>
> ---
>  egl/wayland-egl-symbols-check | 27 +++++++++++++++++++++------
>  1 file changed, 21 insertions(+), 6 deletions(-)
>
> diff --git a/egl/wayland-egl-symbols-check b/egl/wayland-egl-symbols-check
> index c47026b2..70fe1f4c 100755
> --- a/egl/wayland-egl-symbols-check
> +++ b/egl/wayland-egl-symbols-check
> @@ -1,11 +1,17 @@
>  #!/bin/sh
>  set -eu
>
Gut feeling hints that the above set can go.

Regardless, patch is
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

-Emil