[PATCH wayland] wayland-egl: Make symbol test fail on failure

Eric Engestrom eric.engestrom at imgtec.com
Mon Mar 19 16:20:46 UTC 2018


On Monday, 2018-03-19 16:10:57 +0000, Daniel Stone wrote:
> Hi,
> 
> On 19 March 2018 at 16:08, Eric Engestrom <eric.engestrom at imgtec.com> wrote:
> > On Monday, 2018-03-19 15:13:14 +0000, Daniel Stone wrote:
> >> +if ! test -f "$LIB"; then
> >> +     echo "Test binary \"$LIB\" does not exist"
> >> +     exit 99
> >> +fi
> >> +
> >> +if ! test -n "$NM"; then
> >> +     echo "nm environment variable not set"
> >> +     exit 99
> >
> > 99? Were you looking for the "skip this test" 77?
> 
> I did mean 99 'some kind of inexplicable internal error happened'
> rather than 77 skip, but I have no strong opinion on it and am happy
> to change to whatever is suggested.

I guess "don't have the tools to test this, skipping" would be fine, but
I'm not really involved in the wayland project so my opinion isn't the
one that matters the most :P

"I have no strong feelings one way or the other"

> 
> Cheers,
> Daniel


More information about the wayland-devel mailing list