[PATCH weston v4 3/4] simple-dmabuf-drm: 0 is a valid fd (freedreno)

[Eric Engestrom]

On Monday, 2018-03-19 17:45:20 +0100, Guido Günther wrote:
> Signed-off-by: Guido Günther <agx at sigxcpu.org>

It is indeed :)
Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>

> ---
>  clients/simple-dmabuf-drm.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/clients/simple-dmabuf-drm.c b/clients/simple-dmabuf-drm.c
> index a184d7e7..22891639 100644
> --- a/clients/simple-dmabuf-drm.c
> +++ b/clients/simple-dmabuf-drm.c
> @@ -244,10 +244,10 @@ static int
>  fd_bo_export_to_prime(struct buffer *buf)
>  {
>  	buf->dmabuf_fd = fd_bo_dmabuf(buf->fd_bo);
> -	if (buf->dmabuf_fd > 0)
> -		return 0;
> +	if (buf->dmabuf_fd < 0)
> +		return 1;
>  
> -	return 1;
> +	return 0;

Nit: could be simplified as `return buf->dmabuf_fd < 0;`

>  }
>  
>  static int
> -- 
> 2.16.1
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel