[PATCH wayland] wayland-egl: Ignore underscored symbols in ABI check

[Emil Velikov]

On 21 March 2018 at 09:28, Daniel Stone <daniel at fooishbar.org> wrote:
> Hi,
>
> On 21 March 2018 at 08:27, Pekka Paalanen <ppaalanen at gmail.com> wrote:
>> On Tue, 20 Mar 2018 11:46:32 +0000, Daniel Stone <daniel at fooishbar.org> wrote:
>>> inconvenience of maintaining a list of every linker's implementation
>>> detail on every platform, outweighs the risk of an exported
>>> underscore-prefixed symbol slipping through review.
>>
>> how about we make it a coding style rule to not have any symbols
>> starting with an underscore?
>>
>> I don't recall any already being in the code for either Wayland or
>> Weston, but I didn't check. They certainly are not public ABI as the
>> ABI check script would have listed such.
>
> Sure, works for me.
>
Indeed very good suggestion.

>> Aren't symbols (functions, variables) starting with an underscore
>> reserved in C so should not be used anyway?
>
> My recollection is that double-underscore and underscore-uppercase is
> forbidden for use apart from the implementation / standard library,
> and anything else underscore (underscore-number or
> underscore-lowercase) can only be used for static symbols. But I'm
> sure Simon will be along shortly to correct the record. :)
>
The spec does not explicitly state "static symbols" although you're
spot on overall.

-Emil

https://stackoverflow.com/a/10688187