[PATCH weston] Revert "xwm: Add icon support to the frame" and friends

[Daniel Stone]

Hi,

On 29 March 2018 at 15:53, Derek Foreman <derekf at osg.samsung.com> wrote:
> On 2018-03-29 09:10 AM, Derek Foreman wrote:
>> Perhaps I should've been more clear as to what "incomplete" means in
>> this commit log.
>>
>> The current code will pick the first available icon unconditionally,
>> regardless as to whether this fits on the titlebar, and no scaling is done.
>>
>> So, as an example, here running terminology under xwayland will result
>> in picking a 128x128 icon, and drawing it as a 16 high 128 wide piece of
>> the icon on the title bar.  when the window closes for some reason the
>> whole icon appears during fade out.
>>
>> It all looks pretty embarrassing.
>>
>> That said, all the known leaks have been fixed, it's just visually
>> disappointing.
>
> Quentin has suggested on IRC that it might be better to just land the
> xwayland/window-manager.c parts of this revert and keep the rest.

Either sounds reasonable to me, though I have a small preference for
just ripping the whole thing out, and later landing one patch which
works from the get-go with no leaks or visual errors. Scott seems to
be super-active on this, so hopefully we can land this pretty much
right after we branch.

Cheers,
Daniel