[PATCH v2 weston] Partially revert "xwm: Add icon support to the frame" and friends

Daniel Stone daniel at fooishbar.org
Fri Mar 30 16:58:57 UTC 2018


On 30 March 2018 at 17:56, Derek Foreman <derekf at osg.samsung.com> wrote:
> This (partially) reverts commit bef761796c2ada6344d227142af4a0f40b9760dd.
> This (partially) reverts commit 4d1cd36c9ea041688f92cd8981e43b5fe3b52409.
> This (partially) reverts commit 44fc1be913ab2faad0414f50e51d58310302d065.
> This (partially) reverts commit 6b58ea8c43ac81e519bd418efbf24687a5d731b8.
>
> The new xwm icon code has proven to be leaky and incomplete, and while
> we have patches under consideration to fix the rest of its known problems
> they still require changes and review cycles.  Currently the known
> leaks have been squashed, but it still picks wrong sized icons and
> does no scaling, which can lead to very strange rendering.  At window
> close time the wrong sized icon appears above the window during fade out.
>
> This patch reverts the mostly solid bits and keeps the unfinished
> bits behind in favor of a simpler revert than removing the whole
> thing.

Thanks for shepherding through all the fixes and eventually this.

Acked-by: Daniel Stone <daniels at collabora.com>

Cheers,
Daniel


More information about the wayland-devel mailing list