[PATCH libinput] touchpad: fix tapping that happens after a moving thumb

Friedrich Schöller code at schoeller.se
Wed May 9 22:46:02 UTC 2018


On 09.05.2018 06:34, Peter Hutterer wrote:
> On Sat, May 05, 2018 at 03:49:32AM +0200, Friedrich Schöller wrote:
> thanks, patch looks good and is merged locally. Any chance I can convince
> you to write a test case for this? :)
> Would make sure that we're not breaking this again.

Nice to hear! I wrote a test and will post it on the mailing list. However, 
there is a problem with it and all the other tests of thumb detection:

Thumb detection is triggered by setting the pressure to 75. Now this pressure is 
high enough to trigger palm detection as well. That means that all the thumb 
detection tests currently succeed, no matter if thumb detection works or not.

To avoid triggering palm detection, a pressure of 51 or lower is required. But 
this value is too low to trigger thumb detection on all devices.

Should we somehow disable palm detection during the thumb tests?

Best,
Friedrich


More information about the wayland-devel mailing list