[PATCH 0/2] Cleanup weston.ini.in

[Ucan, Emre (ADITG/ESB)]

Hi Michael,

> -----Original Message-----
> From: Michael Tretter [mailto:m.tretter at pengutronix.de]
> Sent: Donnerstag, 24. Mai 2018 14:48
> To: Ucan, Emre (ADITG/ESB) <eucan at de.adit-jv.com>; wayland-
> devel at lists.freedesktop.org
> Subject: Re: [PATCH 0/2] Cleanup weston.ini.in
> 
> Hi,
> 
> On Thu, 24 May 2018 12:06:58 +0000, Ucan, Emre (ADITG/ESB) wrote:
> > You are right that generated ivi-shell/weston.ini file is not
> > suitable to use anywhere else than build directory. It is not usable
> > as it is in RFS of an embedded device.
> >
> > But I did not understand how you fixed this problem with your
> > proposed patches. After I applied your patches and build weston in
> > Yocto environment. Generated weston.ini is still not suitable for the
> > RFS.
> >
> > Snippet:
> >
> > [input-method]
> > path=/usr/libexec/weston-keyboard
> >
> > [ivi-launcher]
> > workspace-id=0
> > icon-id=4001
> > icon=/home/eucan/native-builds/rcar/h07/oe-MGC_COS2.5-rcar-
> gen3/build/tmp/work/aarch64-mel-linux/weston/git-4.0.0-99-g6115933-
> r0/build/../../../../../../../../weston/data/icon_ivi_flower.png
> > path=/home/eucan/native-builds/rcar/h07/oe-MGC_COS2.5-rcar-
> gen3/build/tmp/work/aarch64-mel-linux/weston/git-4.0.0-99-g6115933-
> r0/build/weston-flower
> >
> > input method path is correct for the RFS but launcher paths are still
> > showing build or source directory.
> >
> > Furthermore, ivi-shell/weston.ini file is generated for unit tests of
> > weston, which are executed in build directory. Unit tests of weston
> > would not work with this weston.ini, because input method path is not
> > showing the correct path in build directory.
> >
> > I think generated weston.ini file in build directory has to stay as
> > it is because of unit tests. But we can maybe generate a different
> > weston.ini file in installation phase with install hooks.
> 
> Correct. Weston still generates the same weston.ini as before my
> changes to keep the unit tests working. This is intentional.
> 
> I changed the template to allow you to write a generator for a proper
> weston.ini. Currently, the template assumes that your images are in
> some data/ directory, but the Makefile.am always installs them into
> some weston/ directory. The patches drop the data/ assumption and make
> the full path configurable via the Makefile. This allows you to use the
> weston.ini.in to generate your own weston.ini while still allowing
> Weston to generate a weston.ini that is useful for the unit tests.
> 
> The actual generation of the weston.ini is still up to you. It could be
> done during the Weston installation phase or could be implemented in
> Yocto.

Actually, I was wrong regarding weston tests (: I checked it now.
It is expected that weston tests uses test specific ini files. You can check it here tests/weston-tests-env.

Therefore, we are basically free to use install paths instead of build/src paths. Then, generated ivi-shell/weston.ini would work as it is.
I already implemented a patch to do that. I will send it now to mailing list.

Best Regards,
Emre Ucan
> 
> Michael
> 
> >
> > Best Regards,
> > Emre Ucan
> >
> > > -----Original Message-----
> > > From: wayland-devel [mailto:wayland-devel-
> > > bounces at lists.freedesktop.org] On Behalf Of Michael Tretter
> > > Sent: Mittwoch, 23. Mai 2018 10:35
> > > To: wayland-devel at lists.freedesktop.org
> > > Cc: Michael Tretter <m.tretter at pengutronix.de>
> > > Subject: [PATCH 0/2] Cleanup weston.ini.in
> > >
> > > Hi,
> > >
> > > I am trying to use the IVI-Shell with an embedded system. I'd like
> > > to use the provided weston.ini.in to show case the example
> > > hmi-controller and weston-ivi-shell-user-interface.
> > >
> > > Unfortunately the provided weston.ini.in template is only useful
> > > when used on
> > > the same system that is used to build Weston, because it assumes
> > > that the images are located in a data/ directory, but the images
> > > are actually installed into a weston/ directory. This makes it very
> > > inconvenient to actually show that the example IVI-Shell for demos.
> > >
> > > Instead of using builddir and srcdir (with hard coded
> > > sub-directories), the weston.ini.in should use bindir and datadir,
> > > which can be replaced with arbitrary directories when generating
> > > the weston.ini and make the template useful for more systems.
> > >
> > > Michael
> > >
> > >
> > > Michael Tretter (2):
> > >   ivi-shell: fix path to weston-ivi-shell-user-interface
> > >   weston.ini.in: make config useful for installed Weston
> > >
> > >  Makefile.am             |  6 ++---
> > >  ivi-shell/weston.ini.in | 56
> > > ++++++++++++++++++++--------------------- weston.ini.in
> > > |  2 +- 3 files changed, 32 insertions(+), 32 deletions(-)
> > >
> > > --
> > > 2.17.0
> > >
> > > _______________________________________________
> > > wayland-devel mailing list
> > > wayland-devel at lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/wayland-devel