[PATCH v2] protocol: prefer wl_surface.damage_buffer

[Pekka Paalanen]

On Mon, 05 Nov 2018 13:57:00 +0000
Simon Ser <contact at emersion.fr> wrote:

> This commit makes wl_surface.damage_buffer preferred over wl_surface.damage.
> wl_surface.damage can be implemented in a non-optimal way by the compositor
> (e.g. by always damaging the whole buffer).
> 
> Having two requests makes it complicated for the compositor to handle damage,
> making it necessary to transform one into the other's coordinates.
> 
> Moreover, integration with wp_viewporter is tricky.
> 
> Signed-off-by: Simon Ser <contact at emersion.fr>
> ---
>  protocol/wayland.xml | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/protocol/wayland.xml b/protocol/wayland.xml
> index 141038b..df2b6d2 100644
> --- a/protocol/wayland.xml
> +++ b/protocol/wayland.xml
> @@ -1397,9 +1397,9 @@
>  	and clears pending damage. The server will clear the current
>  	damage as it repaints the surface.
>  
> -	Alternatively, damage can be posted with wl_surface.damage_buffer
> -	which uses buffer coordinates instead of surface coordinates,
> -	and is probably the preferred and intuitive way of doing this.
> +        Note! New clients should not use this request. Instead damage can be
> +        posted with wl_surface.damage_buffer which uses buffer coordinates
> +        instead of surface coordinates.
>        </description>
>        <arg name="x" type="int" summary="surface-local x coordinate"/>
>        <arg name="y" type="int" summary="surface-local y coordinate"/>

Acked-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20181105/b018b490/attachment.sig>