[PATCH] protocol: deprecate wl_surface.damage

[Derek Foreman]

On 11/5/18 7:43 AM, Simon Ser wrote:
> On Monday, November 5, 2018 11:07 AM, Pekka Paalanen <ppaalanen at gmail.com> wrote:
>> How about writing what Derek said: that the old damage request may be
>> unoptimal rather than deprecated.
>>
>> I don't like "deprecated" because to me it implies that this request
>> will be removed (i.e. can be left unimplemented) some time in the future.
> 
> Fair enough, I'll rephrase with words like "should" and "preferred".
> 
> It would be nice to really deprecate this request at some point.

Have we ever considered having a way to deprecate requests (beyond
deprecating entire xml files like the old xdg versions)?

We could generate compile time warnings and perhaps print a log message.

Actually removing protocol might be kind of scary, but we can give
people some way to know that they might get better performance with some
changes.

Or is this so infrequent an occurrence that it doesn't need to be
bothered with?

Thanks,
Derek

>> Xwayland is still using exclusively wl_surface.damage, for instance.
> 
> Sent a patch to fix this [1].
> 
> [1]: https://lists.x.org/archives/xorg-devel/2018-November/057678.html
>