[PATCH wayland] protocol: Bump seat to version 7 and require keymaps be private

Derek Foreman derek.foreman.samsung at gmail.com
Fri Nov 30 15:30:40 UTC 2018


On 11/2/18 6:15 AM, Pekka Paalanen wrote:
> On Thu,  1 Nov 2018 11:15:46 -0500
> Derek Foreman <derek.foreman.samsung at gmail.com> wrote:
> 
>> Weston commit 76829fc4eaea329d2a525c3978271e13bd76c078 (and similar
>> commits for other compositors) protects the compositor's keyboard
>> mapping from client damage by duplicating the keymap for every
>> client.
>>
>> On some systems there are other potential fixes for this - such as
>> using sealed memfds on linux - but we can't use them since
>> essentially all client code anywhere has mapped the keyboard map
>> with a MAP_SHARED mmap() call.
>>
>> While we can't break years worth of code, we can require any future
>> clients to use MAP_PRIVATE if they use a seat version above 6.
>>
>> If a compositor can't use sealing or a similar facility, it should
>> still protect itself with copied keymaps, but clients must always
>> assume shared mapping of a keymap will fail.
>>
>> Signed-off-by: Derek Foreman <derek.foreman.samsung at gmail.com>
>> ---
>>  protocol/wayland.xml | 11 +++++++----
>>  1 file changed, 7 insertions(+), 4 deletions(-)
> 
> Acked-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>

And landed now.

Thanks,
Derek

> 
> Thanks,
> pq
> 



More information about the wayland-devel mailing list