[PATCH wayland-protocols v2] unstable: add primary-selection protocol

Simon Ser contact at emersion.fr
Wed Oct 10 12:31:09 UTC 2018


Thanks for your review, Jonas.

Carlos, what do you think of this proposal?

Thanks,

Simon.

On Thursday, October 4, 2018 12:06 PM, Jonas Ådahl <jadahl at gmail.com> wrote:
> On Sun, Sep 23, 2018 at 10:52:34AM +0000, Simon Ser wrote:
>
> > From: emersion contact at emersion.fr
> > This primary selection is similar in spirit to the eponimous
> > in X11, allowing a quick "select text + middle click" shortcut
> > to copying and pasting.
> > It's otherwise very similar to its Wayland counterpart, and
> > explicitly made consistent with it.
> > Signed-off-by: Simon Ser contact at emersion.fr
>
> Reviewed-by: Jonas Ådahljadahl at gmail.com
>
> with one minor nit below. I'd prefer to get another RB or Ack (by Carlos
> eg) before landing.
>
> > Changes from v1 to v2: renamed with the wp_ prefix
> > Makefile.am | 3 +-
> > unstable/primary-selection/README | 4 +
> > .../primary-selection-unstable-v1.xml | 226 ++++++++++++++++++
> > 3 files changed, 232 insertions(+), 1 deletion(-)
> > create mode 100644 unstable/primary-selection/README
> > create mode 100644 unstable/primary-selection/primary-selection-unstable-v1.xml
> > diff --git a/Makefile.am b/Makefile.am
> > index 6394e26..aca32c2 100644
> > --- a/Makefile.am
> > +++ b/Makefile.am
> > @@ -20,7 +20,8 @@ unstable_protocols = \
> > unstable/keyboard-shortcuts-inhibit/keyboard-shortcuts-inhibit-unstable-v1.xml \
> > unstable/xdg-output/xdg-output-unstable-v1.xml \
> > unstable/input-timestamps/input-timestamps-unstable-v1.xml \
> >
> > -   unstable/xdg-decoration/xdg-decoration-unstable-v1.xml \
> >
> > -   unstable/xdg-decoration/xdg-decoration-unstable-v1.xml \
>
> Accidental change (tabs -> spaces) above.
>
> Jonas



More information about the wayland-devel mailing list