[PATCH] linux-dmabuf: un-deprecate format events

Chia-I Wu olvaffe at gmail.com
Wed Apr 10 21:00:12 UTC 2019


On Wed, Apr 10, 2019 at 12:40 PM Simon Ser <contact at emersion.fr> wrote:

> On Wednesday, April 10, 2019 9:25 PM, Chia-I Wu <olvaffe at gmail.com> wrote:
> > Both implementations support formats that have no explicit modifiers.
> > But when it comes to buffer creation, modifier_hi/lo is required
> > again.  It is unclear how to create a buffer for such formats.
> >
> > This patch tries to clarify these issues, leaning toward mutter's
> > behavior.
>
> Is there a reason to standardize Mutter's behavior instead of Weston's
> and wlroots'? (Don't know about others)
>
Frankly, there was no clear, strong argument to prefer one over the other
to me.  Things I can think of are

 - it is more intuitive to have format events for formats and modifier
events for modifiers
 - having both events makes the protocol more similar to EGL's
equeglQueryDmaBufFormatsEXT
/ eglQueryDmaBufModifiersEXT

I should bring this up that standardizing on Mutter's behavior means Weston
and others require fixes, to send format events at least.  But
standardizing on Weston's behavior means Mutter still works to some degree:
it only loses formats that have no explicit modifiers because format events
will be ignored.  But that degree of compatibility is not enough if the
goal is to replace wl_drm ultimately.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20190410/8317c8a5/attachment.html>


More information about the wayland-devel mailing list