[PATCH wayland-protocols] xdg-output: deprecate the xdg_output.done event
ofourdan at redhat.com
Mon Apr 29 07:22:40 UTC 2019
On Mon, Apr 29, 2019 at 9:05 AM Simon Ser <contact at emersion.fr> wrote:
> On Monday, April 29, 2019 9:51 AM, Olivier Fourdan <ofourdan at redhat.com>
> > > On Sunday, April 28, 2019 12:04 PM, Olivier Fourdan <
> ofourdan at redhat.com> wrote:
> > IMHO, it would better, semantically, to keep `xdg-output.done` and
> > clarify (in xdg-output) that the `xdg-output.done` event is sent once
> > all properties on wl_output _and_ xdg-output are set, xdg-output
> > being a superset of wl_output. This way we would keep things apart
> > but also still guarantee atomicity.
> What if we have another protocol that extends wl_output? How can you
> atomically send xdg_output state and the other protocol's state?
> This solution doesn't scale.
Humm, that's a good point.
> Besides, that would be easier on the existing clients that would
> > (still) expect the `xdg-output.done` event and compositors that
> > wouldn't need to emit the event based on the protocol version used by
> > the client.
> That's a good point. I still think it's worth it to properly fix this
Then we have no choice but bumping the protocol version to differentiate
those client which expect the xdg-output.done from those who won't.
> > > [...]
> > > GNOME also doesn't expose all output properties IIRC: the whole list of
> > > output modes is not sent.
> > It does, mutter sends the full list of outputs with their size, scale
> > and position and gtk+ relies on it for its GdkMonitor, although there
> > are plans to move gtk to use xdg-output as well for its GdkMonitor
> > definitions.
> The whole list of outputs is sent, however the whole list of output
> *modes* isn't. Only the current mode is sent.
> I don't think GTK+ should rely on output positions, modes or logical
gtk itself doesn't rely on it, but exposes it via its GdkMonitor API and
gtk based applications (such as Firefox) may use it.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the wayland-devel