[PATCH wayland-protocols] xdg-shell: Add support for synchronized popup moving

David Edmundson david at davidedmundson.co.uk
Tue Aug 27 22:47:25 UTC 2019


set_reactive

Everything about this part makes sense.
+1


-----

move request + moved

Concept of having explicit updating makes sense.
Might be worth considering calling it xdg_popup.reposition as
xdg_toplevel.move is very different

Would it be valid to re-use the same positioner object each time?

Could we repurpose wl_display.sync as an alternative for the moved
signal? Simply for code re-use.
It slightly reverses the logic, but after your callback a client knows
it definitely has the latest configure event for your move request.

-----

sync_with_popup

In example A

 --> xdg_toplevel.configure(200, 600)
 --> xdg_popup_surface.configure(3)
 <-- xdg_popup_surface.ack_configure(3)
 <-- xdg_popup_surface.sync_with_popup(xdg_popup)

Should this be xdg_toplevel_surface?


More information about the wayland-devel mailing list