[PATCH wayland 1/1] contributing: use Gitlab merge request workflow
contact at emersion.fr
Tue Feb 26 14:57:30 UTC 2019
On Tuesday, February 26, 2019 2:42 PM, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> From: Pekka Paalanen <pekka.paalanen at collabora.com>
> The experience from Weston shows that the Gitlab merge request based workflow
> works really well. Recently there have also been issues with the mailing list
> that have made the email based workflow more painful than it used to be. Those
> issues might have been temporary or occasional, but they probably are only
> going to increase.
> The MR workflow is different, it has its issues
> (https://gitlab.freedesktop.org/freedesktop/freedesktop/issues/74) and we
> likely lose the explicit Reviewed-by etc. tags from commit messages, but it is
> also much easier to work with: no more whitespace damaged patches, lost email,
> setting up git-send-email; we gain automated CI before any human reviewer even
> looks at anything, and people can jump in to an ongoing discussion even if they
> weren't subscribed before.
> If you still want email, you can subscribe to that selectively(!) in Gitlab
> This text has been copied from Weston's CONTRIBUTING.md of the 5.0.91 release
> and slightly altered for Wayland.
> Fixes: https://gitlab.freedesktop.org/wayland/wayland/issues/49
> Signed-off-by: Pekka Paalanen <pekka.paalanen at collabora.com>
This seems to make it easier and friendlier for maintainers to review and merge
patches. I think this is pretty important. The CI integration is also a big win.
Reviewed-by: Simon Ser <contact at emersion.fr>
More information about the wayland-devel