Few patches from Ravenports for DragonFly BSD support

[Pekka Paalanen]

On Sun, 20 Jan 2019 07:59:26 +0200
Leonid Bobrov <mazocomp at disroot.org> wrote:

> From 660f1a59a0ff09f1c21e97087b713d6751e3de10 Mon Sep 17 00:00:00 2001
> From: Leonid Bobrov <mazocomp at disroot.org>
> Date: Sun, 20 Jan 2019 07:33:46 +0200
> Subject: [PATCH] Few patches from Ravenports for DragonFly BSD support
> 
> Taken from https://github.com/jrmarino/ravensource/tree/master/bucket_D7/wayland/patches
> ---
>  cursor/wayland-cursor.c |  4 ++++
>  src/scanner.c           |  2 +-
>  src/wayland-server.c    | 34 +++++++++++++++++++++++++++++++---
>  src/wayland-util.c      |  1 +
>  tests/test-compositor.c | 26 ++++++++++++++++++++++++--
>  tests/test-runner.c     | 33 +++++++++++++++++++++++++++++++++
>  6 files changed, 94 insertions(+), 6 deletions(-)

Hi,

you need to split this into logical patches, each patch doing one
logical thing. It is not the same as one patch per file. Each patch
needs to have a commit message explaining why the patch was written,
and so on. Please, see
https://gitlab.freedesktop.org/wayland/wayland/blob/master/CONTRIBUTING.md

As for merging, I think I saw some bits that don't actually need any
#ifdef BSD guards but would be good fixes regardless of the OS. Patches
that do not depend on a specific OS I think we can land without having
a BSD in CI, but patches that depend on being built on a BSD should
come with CI. I won't personally have the time to figure out how to run
a BSD in Gitlab CI, someone else needs to write the patch.

It would also be good to instead of hardcoding things like
#if Dragonfly /* no mremap */ to have autoconf test for the existence of
mremap, since the fallback to munmap+mmap seems quite generic.


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20190124/4b9e9f88/attachment.sig>