[PATCH wayland-protocols v2] pointer-gestures: add a release request

[Jonas Ådahl]

On Mon, Jan 28, 2019 at 08:33:55AM +0000, Simon Ser wrote:
> This allows clients to destroy a gesture object before they disconnect.
> 
> The request isn't named "destroy", as this would conflict with
> wayland-scanner's auto-generated destructor (which just destroys the
> client-side object without sending any request).
> 
> Signed-off-by: Simon Ser <contact at emersion.fr>
> ---
> 
> Changes in v2: rename to release, thanks Jonas for pointing this mistake out.
> 
>  .../pointer-gestures-unstable-v1.xml                | 13 ++++++++++---
>  1 file changed, 10 insertions(+), 3 deletions(-)
> 
> diff --git a/unstable/pointer-gestures/pointer-gestures-unstable-v1.xml b/unstable/pointer-gestures/pointer-gestures-unstable-v1.xml
> index 5b7132c..dd9a52e 100644
> --- a/unstable/pointer-gestures/pointer-gestures-unstable-v1.xml
> +++ b/unstable/pointer-gestures/pointer-gestures-unstable-v1.xml
> @@ -1,7 +1,7 @@
>  <?xml version="1.0" encoding="UTF-8"?>
>  <protocol name="pointer_gestures_unstable_v1">
>  
> -  <interface name="zwp_pointer_gestures_v1" version="1">
> +  <interface name="zwp_pointer_gestures_v1" version="2">
>      <description summary="touchpad gestures">
>        A global interface to provide semantic touchpad gestures for a given
>        pointer.
> @@ -37,9 +37,16 @@
>        <arg name="id" type="new_id" interface="zwp_pointer_gesture_pinch_v1"/>
>        <arg name="pointer" type="object" interface="wl_pointer"/>
>      </request>

We usually add a 

   </request>
+
+  <!-- Version 2 additions -->
+
+  <request>
+    ...

to make it clearer what is part of a new version.

With that fixed, this is 

Reviewed-by: Jonas Ådahl <jadahl at gmail.com>


Jonas

> +
> +    <request name="release" type="destructor" since="2">
> +      <description summary="destroy the pointer gesture object">
> +	Destroy the pointer gesture object. Swipe and pinch objects created via this
> +	gesture object remain valid.
> +      </description>
> +    </request>
>    </interface>
>  
> -  <interface name="zwp_pointer_gesture_swipe_v1" version="1">
> +  <interface name="zwp_pointer_gesture_swipe_v1" version="2">
>      <description summary="a swipe gesture object">
>        A swipe gesture object notifies a client about a multi-finger swipe
>        gesture detected on an indirect input device such as a touchpad.
> @@ -102,7 +109,7 @@
>      </event>
>    </interface>
>  
> -  <interface name="zwp_pointer_gesture_pinch_v1" version="1">
> +  <interface name="zwp_pointer_gesture_pinch_v1" version="2">
>      <description summary="a pinch gesture object">
>        A pinch gesture object notifies a client about a multi-finger pinch
>        gesture detected on an indirect input device such as a touchpad.
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel