[PATCH] xdg-shell: add use case to handle change of app_id

[Simon Ser]

> LibreOffice is one big binary with explicit brandings for different
> application modules. This is represented by different WM_CLASS
> settings for a window on X11, based on the loaded document. As a
> result LibreOfiice already offers multiple desktop files with
> different icons and StartupWMClass entries.
>
> This amendment of the set_app_id request just explicitly specifies
> this use case to change a windows app_id on runtime to change icon
> and grouping of a window as used by LibreOffice.
> ---
>  stable/xdg-shell/xdg-shell.xml | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/stable/xdg-shell/xdg-shell.xml b/stable/xdg-shell/xdg-shell.xml
> index 2e420c6..fd3670f 100644
> --- a/stable/xdg-shell/xdg-shell.xml
> +++ b/stable/xdg-shell/xdg-shell.xml
> @@ -604,6 +604,11 @@
>  	For example, "org.freedesktop.FooViewer" where the .desktop file is
>  	"org.freedesktop.FooViewer.desktop".
>
> +	This request can be used to change the icon of a window at runtime by
> +	providing different desktop files and changing the app_id.

I'm not sure this change is necessary. Nothing says this request can't be sent
after the toplevel has been setup. Other requests don't explicitly specify they
can be sent after setup.

> Windows of
> +	the same app_id will still be grouped together, as they are expected
> +	to represent the same application from the users point of view.

This should be left out, because this is compositor policy. Some compositors
don't group by app_id.

>  	See the desktop-entry specification [0] for more details on
>  	application identifiers and how they relate to well-known D-Bus
>  	names and .desktop files.
> --
> 2.20.1
>
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel