[PATCH wayland-protocols] xdg-output: make xdg_output.description mutable

Daniel Stone daniel at fooishbar.org
Mon Jun 24 10:29:21 UTC 2019


Hi,

On Sat, 27 Apr 2019 at 09:16, Simon Ser <contact at emersion.fr> wrote:
> The output description is a human-readable text describing the output. Unlike
> the name which uniquely identifies the output, it's intended to be displayed to
> the user.
>
> It might be desirable for a compositor to update an output's description. For
> instance, when only one output is plugged in, it's not necessary to dump make,
> model, serial and connector to the description, something like "Dell U2717D" is
> enough. However when two identical outputs are plugged in it's necessary to add
> e.g. the connector type to tell them apart ("Dell U2717D on HDMI"). See [1] for
> a discussion about this.
>
> This commit bumps xdg_output's version to allow compositors to update the
> property.

We definitely need to figure out 'done', and ideally have it come in
the same version bump, but with that and one small nitpick resolved
this is:
Acked-by: Daniel Stone <daniels at collabora.com>

-       xdg_output_manager.get_xdg_output). This event is only sent once per
+       xdg_output_manager.get_xdg_output) and whenever the description
+       changes. The description is optional, and may not be sent at all.

To be honest, rather than have the clients open-code their own '(no
description)' strings - and some of them will definitely forget to do
it - I would keep the requirement that it is sent during initial
advertisement.

Cheers,
Daniel


More information about the wayland-devel mailing list