[PATCH 1/2] hdr-metadata: Add protocol for static HDR metadata

Simon Ser contact at emersion.fr
Mon Mar 11 21:12:26 UTC 2019

On Monday, March 11, 2019 9:53 PM, Harish Krupo <harish.krupo.kps at intel.com> wrote:
> Thanks for the comments. Please find my comments inline.

Thank you for working on this!


> >> +      An extension interface to the wl_surface object to set the HDR metadata
> >> +      associated with the surface.
> >> +    </description>
> >> +
> >> +    <enum name="EOTF">
> >
> > Style nit: this can be lowercase.
> >
> Enum names lowercase?

Yeah, that's the convention we've been using so far.


> Thanks again for reviewing. As this is just a provisional protocol, we
> didn't give much heed to the exact details. I agree that it shouldn't be
> the case. I will update this protocol with more details and send in v2.

I see. No rush then, I'll wait for the next version. :)

I have similar comments for the second part of this patchset, but I'm going to
hold off until v2 is sent.

More information about the wayland-devel mailing list