[PATCH wayland-protocols] presentation-time: add missing bitfield marker

Victor Berger victor.berger at m4x.org
Thu Sep 5 12:41:44 UTC 2019


30 août 2019 14:18 "Daniel Stone" <daniel at fooishbar.org> a écrit:

> Hi,
> On Fri, 30 Aug 2019 at 08:45, Pekka Paalanen <ppaalanen at gmail.com> wrote:
>> I don't recall hearing much from people with custom code generating
>> scanners, so until we upset someone and they come to us complaining
>> about regressions the first time, I am fine with adding these
>> annotations that do not break the ABI generated by wayland-scanner.
>> When we started introducing these new attributes that may "break" the
>> consumers of code generated by custom scanners, we had a discussion
>> about this very issue. If I remember right, everyone involved at the
>> time were happy with the "break" since the benefits will be greater
>> than the damage in the long run. IIRC Victor was there then, and he
>> said the same now.
>> From my behalf:
>> Acked-by: Pekka Paalanen <pekka.paalanen at collabora.com>
>> Do you need me to land this?
>> Since wayland-protocols is still using email workflow, please give all
>> your Reviewed-by and Acked-by tags explicitly.
> With the same rationale - this will only hurt people generating rich
> bindings, who are the exact people who want it - this is:
> Acked-by: Daniel Stone <daniels at collabora.com>

Wayland-rs will always welcome such corrections of the the protocol files.

Acked-by: Victor Berger <victor.berger at m4x.org>

Victor Berger.

More information about the wayland-devel mailing list