[RFC] protocol: Suggestion for wl_data_offer.finish request description improvement

[hippyandy]

Hi all,

I hope this email finds you well. I’ve been reviewing the documentation for the wl_data_offer.finish request and would like to suggest a few minor improvements to enhance clarity and correctness.







Current Description:

``

Notifies the compositor that the drag destination successfully finished the drag-and-drop operation.

Upon receiving this request, the compositor will emit wl_data_source.dnd_finished on the drag source client.

It is a client error to perform other requests than wl_data_offer.destroy after this one.

It is also an error to perform this request after a NULL mime type has been set in wl_data_offer.accept or no action was received through wl_data_offer.action.

If wl_data_offer.finish request is received for a non drag and drop operation, the invalid_finish protocol error is raised.

</description>

"It is also an error to perform this request after a NULL mime type has been set in wl_data_offer.accept or no action was received through wl_data_offer.action."

``







Suggested Changes:

Replace "no action" with "none action" in the sentence:

Original: "or no action was received through wl_data_offer.action."

Suggested: "or none action was received through wl_data_offer.action."

(Note: This change assumes "none action" is the intended phrasing. If "no action" is technically correct, please disregard this suggestion.)

Clarify the subject in the last sentence for better readability:

Original: "If wl_data_offer.finish request is received for a non drag and drop operation..."

Suggested: "If the compositor received wl_data_offer.finish request for a non drag and drop operation..."







Rationale:

The first change aligns with potential grammatical preferences (though "no action" may also be correct; please verify the intended phrasing).

The second change makes it explicit that the compositor is the entity handling the request, improving clarity.

These adjustments aim to make the documentation more precise while retaining its original meaning. Thank you for considering these suggestions. Please let me know if further clarification would be helpful.

Best regards,




苏怀安
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20250409/e7eb230a/attachment.htm>