> +void drm_colorop_set_next_property(struct drm_colorop *colorop, struct drm_colorop *next) > +{ > + if (!colorop->next_property) > + return; Why is this early return necessary? Shouldn't this field be always populated? Even if that's not the case, I don't think silently ignoring the call is a good idea.