[PATCH V8 10/43] drm/plane: Add COLOR PIPELINE property

Simon Ser contact at emersion.fr
Sat Mar 29 14:33:27 UTC 2025


Two nits below, regardless:

Reviewed-by: Simon Ser <contact at emersion.fr>

> +	} else if (property == plane->color_pipeline_property) {
> +		/* find DRM colorop object */
> +		struct drm_colorop *colorop = NULL;
> +
> +		colorop = drm_colorop_find(dev, file_priv, val);
> +
> +		if (val && !colorop)
> +			return -EACCES;
> +
> +		/* set it on drm_plane_state */
> +		drm_atomic_set_colorop_for_plane(state, colorop);

Nit: I don't think these comments are especially useful, the names of the
functions are clear enough.

> +int drm_plane_create_color_pipeline_property(struct drm_plane *plane,
> +					     const struct drm_prop_enum_list *pipelines,
> +					     const int num_pipelines)

Nit: in general we don't mark non-pointer arguments as const: the function
cannot mutate the caller's value anyways.


More information about the wayland-devel mailing list