<div dir="ltr">2016-03-03 20:17 GMT+01:00 Юрий Шведов <span dir="ltr"><<a href="mailto:shved@lvk.cs.msu.su" target="_blank">shved@lvk.cs.msu.su</a>></span>:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div>Ok, I understood why did you do so, and now I see, where did you take the code.<br>
<br>
The reason, why I change that is to remove unnecessary macro parce_name, which can be replaced by inline function, and merge two functions to one with the same functionality and code reduce. But my mistake isthet I forgot about code reuse.<br>
<br>
About the name - I changed it to make it short anough to suite the help-message alignment.<br>
<br>
My suggestion is to add the array to my parcer as parameter, rename it to name_to_enum, and make parse_compression_name the function like your macro.<br></div></blockquote><div><br></div><div>If I understand good probably ok.<br></div><div>Another thing is the message/errors in case of invalid value, missed in your commit, ok that copy I did was not good but do nothing at all I think is bad.<br><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div>
<br>
What do you think?<br><br><div class="gmail_quote">3 марта 2016 г. 19:36:51 GMT+01:00, Fabio Fantoni <<a href="mailto:fabio.fantoni@m2r.biz" target="_blank">fabio.fantoni@m2r.biz</a>> пишет:<div><div class="h5"><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">2016-03-03 18:57 GMT+01:00 Yury Shvedov <span dir="ltr"><<a href="mailto:shved@lvk.cs.msu.su" target="_blank">shved@lvk.cs.msu.su</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
I cherry-picked your commits to my <a href="https://github.com/ein-shved/compositor-spice/commits/spice" target="_blank">repo</a>
with some modifications. Take a look if you want =).<span><br></span></div></blockquote><div><br></div><div>I saw your change, compression option I think should be image compression or similar because is an image compression (lossless), there are also other compression parameters I'll add (probably starting from the lossy compression for wan).<br></div><div>About 2 functions (<span><span>name2enum and </span></span><span><span>parse_name</span></span>) use for now only by image compression will be used also by other parameters and is good to have it out to avoid too many "duplicate code".<br></div><div>Take a look here for example:<br><a href="http://git.qemu.org/?p=qemu.git;a=blob;f=ui/spice-core.c" target="_blank">http://git.qemu.org/?p=qemu.git;a=blob;f=ui/spice-core.c</a> (qemu should have all spice features FWIK)<br><a href="https://cgit.freedesktop.org/xorg/driver/xf86-video-qxl/tree/src/spiceqxl_spice_server.c" target="_blank">https://cgit.freedesktop.org/xorg/driver/xf86-video-qxl/tree/src/spiceqxl_spice_server.c</a> (xspice probably don't have all spice features)<br></div><div>I don't mean to do same code but at least <span lang="en"><span>consider future add of other features, some are fast/easy to add, other require bigger think as prerequisite (vdagent, usbredir ecc...)<br></span></span></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div text="#000000" bgcolor="#FFFFFF"><span>
<br>
<div>On 03/03/2016 05:23 PM, Fabio Fantoni
wrote:<br>
</div>
<blockquote type="cite">
<div>Il 03/03/2016 17:03, Yury Shvedov ha
scritto:<br>
</div>
<blockquote type="cite">
<br>
<br>
<div>On 03/03/2016 04:40 PM, Fabio
Fantoni wrote:<br>
</div>
<blockquote type="cite">
host and port parameter are working, added also in
documentation<br>
</blockquote>
Perfect! Thank you!<br>
<blockquote type="cite"> <span lang="en"><span>It is not</span> <span>a problem</span><span>
for me,</span> <span>I</span> <span>do it quickly.<br>
</span></span></blockquote>
Ok, it is up to you.<br>
<blockquote type="cite"><span lang="en"><span> I did very fast some small commits:<br>
<a href="https://github.com/Fantu/compositor-spice/commits/rebase/spice-1.10" target="_blank">https://github.com/Fantu/compositor-spice/commits/rebase/spice-1.10</a><br>
Based on latest stable to avoid regression not related to
spice.<br>
</span></span></blockquote>
Thank you! But there are some points in <a href="https://github.com/Fantu/compositor-spice/commit/61e87fe3047acf5a4ef69f8aeafba6a8f5409a9a" target="_blank">image
compression commit</a> I don't really like. For example
exit(1). I will suggest some additions soon. Will discuss =)<br>
</blockquote>
<br>
Sorry I did it in few minutes looking qemu and xspice and I not
modified it like looking other weston things. <br>
</blockquote></span>
Don't worry there are many bad places in my code need to be fixed.<span><br>
<blockquote type="cite"> <br>
<blockquote type="cite">
<blockquote type="cite"><span lang="en"><span> I did fast test connecting from lan computer
and is working.<br>
</span></span></blockquote>
Good to hear!<br>
<blockquote type="cite"><span lang="en"><span> You should able to cherry-pick all commits
after "Add Spice compositor" without problem if the
commits are ok for you.<br>
</span></span></blockquote>
<blockquote type="cite"><span lang="en"><span> In the weekend probably I'll add other spice
features support.<br>
</span></span></blockquote>
I hope I'll be it time with new Spice API and warnings fixing.<br>
<pre cols="72">--
Kind Regards,
Yury Shvedov </pre>
</blockquote>
<br>
</blockquote>
<br>
<pre cols="72">--
Kind Regards,
Yury Shvedov </pre>
</span></div>
</blockquote></div><br></div></div>
</blockquote></div></div></div><div><div class="h5"><br>
-- <br>
Kind Regards,<br>
Yury Shvedov</div></div></div></blockquote></div><br></div></div>