<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On 18 July 2016 at 12:09, Eric Engestrom <<a href="mailto:eric.engestrom@imgtec.com" target="_blank">eric.engestrom@imgtec.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Mon, Jul 18, 2016 at 09:53:20AM +0100, Eric Engestrom wrote: > On Sat, Jul 16, 2016 at 11:32:49PM +0300, Jussi Kukkonen wrote: > > This fixes build on musl. > > > > Signed-off-by: Jussi Kukkonen <<a href="mailto:jussi.kukkonen@intel.com" target="_blank">jussi.kukkonen@intel.com</a>> > > Reviewed-by: Eric Engestrom <<a href="mailto:eric.engestrom@imgtec.com" target="_blank">eric.engestrom@imgtec.com</a>> Actually, a quick grep tells me 92 other files could use the same treatment: clients/editor.c clients/eventdemo.c clients/ivi-shell-user-interface.c clients/keyboard.c clients/multi-resource.c clients/nested-client.c clients/presentation-shm.c clients/scaler.c clients/simple-damage.c clients/simple-dmabuf-intel.c clients/simple-dmabuf-v4l.c clients/simple-egl.c clients/simple-shm.c clients/simple-touch.c clients/stacking.c clients/weston-info.c clients/weston-simple-im.c clients/window.h compositor/cms-colord.c compositor/cms-helper.c compositor/main.c compositor/screen-share.c compositor/text-backend.c compositor/weston-screenshooter.c desktop-shell/exposay.c desktop-shell/input-panel.c desktop-shell/shell.c desktop-shell/shell.h fullscreen-shell/fullscreen-shell.c ivi-shell/hmi-controller.c ivi-shell/input-panel-ivi.c ivi-shell/ivi-layout.c ivi-shell/ivi-layout-export.h ivi-shell/ivi-layout-private.h ivi-shell/ivi-layout-transition.c ivi-shell/ivi-shell.c ivi-shell/ivi-shell.h libweston/animation.c libweston/bindings.c libweston/clipboard.c libweston/compositor-drm.c libweston/compositor-fbdev.c libweston/compositor-fbdev.h libweston/compositor.h libweston/compositor-headless.c libweston/compositor-headless.h libweston/compositor-rdp.c libweston/compositor-wayland.c libweston/compositor-wayland.h libweston/compositor-x11.c libweston/compositor-x11.h libweston/data-device.c libweston/dbus.c libweston/gl-renderer.c libweston/gl-renderer.h libweston/launcher-logind.c libweston/launcher-util.c libweston/launcher-weston-launch.c libweston/libbacklight.c libweston/libinput-device.c libweston/libinput-seat.c libweston/linux-dmabuf.c libweston/noop-renderer.c libweston/pixman-renderer.c libweston/screenshooter.c libweston/spring-tool.c libweston/timeline.c libweston/zoom.c shared/config-parser.c shared/config-parser.h shared/frame.c shared/image-loader.c shared/xalloc.c tests/buffer-count-test.c tests/internal-screenshot-test.c tests/ivi_layout-internal-test.c tests/ivi_layout-test.c tests/ivi_layout-test-plugin.c tests/keyboard-test.c tests/presentation-test.c tests/surface-global-test.c tests/surface-screenshot.c tests/text-test.c tests/weston-test.c tests/weston-test-client-helper.c tests/weston-test-client-helper.h wcap/wcap-decode.h xwayland/dnd.c xwayland/hash.h xwayland/launcher.c xwayland/selection.c xwayland/window-manager.c I expect most of them build fine because somewhere in the include chain, some other header includes it for them, but IMHO the #include line should be explicitly there anyway. Would you like to send a patch for those as well? </blockquote><div> </div><div>You just completely foiled the getaway of my otherwise successful drive-by-patching.</div><div> </div><div>I mean, sure I guess I can do that.</div><div> </div><div> - Jussi</div></div></div></div>