Hi Derek,<br><br>On Friday, 30 September 2016, Derek Foreman <<a href="mailto:derekf@osg.samsung.com">derekf@osg.samsung.com</a>> wrote:<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+static bool<br>
+viewport_is_cursor_<wbr>compatible(struct weston_buffer_viewport *viewport)<br>
+{<br>
+       /* While we could technically relax soem of these constraints<br>
+        * if we implemented cropping in cursor_bo_update, it doesn't<br>
+        * seem worth the effort.<br>
+        * It is also possible to more thoroughly test if src and dst<br>
+        * sizes match when widths aren't -1, but again, likely not<br>
+        * worth the complexity.<br>
+        */<br>
+       if (viewport->surface.width != -1)<br>
+               return false;<br>
+       if (wl_fixed_to_int(viewport-><wbr>buffer.src_x) != 0)<br>
+               return false;<br>
+       if (wl_fixed_to_int(viewport-><wbr>buffer.src_y) != 0)<br>
+               return false;<br>
+       if (wl_fixed_to_int(viewport-><wbr>buffer.src_width) != -1)<br>
+               return false;<br>
+       if (viewport->surface.width != -1)<br>
+               return false;</blockquote><div><br></div><div>Presumably one of these should be height, and are we not missing a src_height check too? Also, might as well merge the buffer_scale check in here too.</div><div><br></div><div>Cheers,</div>Daniel<br><br>