<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">I'm not at all familiar with the internal implementation of ivi-shell, so I can't give much meaningful review. But I am very much in favor of this patch series. Without wl_shell and xdg_shell support, I've never been able to really give ivi-shell serious consideration on my products. The ability to use generic client Wayland programs is very important.</div><div class="gmail_quote"> </div><div class="gmail_quote">-Matt</div><div class="gmail_quote"> </div><div class="gmail_quote">On Tue, Oct 17, 2017 at 5:51 AM, Ucan, Emre (ADITG/ESB) <<a href="mailto:eucan@de.adit-jv.com" target="_blank">eucan@de.adit-jv.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi, I already reviewed the patches before Michael sent: Reviewed-by: Emre Ucan <<a href="mailto:eucan@de.adit-jv.com">eucan@de.adit-jv.com</a>> Best regards Emre Ucan Engineering Software Base (ADITG/ESB) Tel. <a href="tel:%2B49%205121%2049%206937" value="+495121496937">+49 5121 49 6937</a> <div class="HOEnZb"><div class="h5"> > -----Original Message----- > From: wayland-devel [mailto:<a href="mailto:wayland-devel-">wayland-devel-</a> > <a href="mailto:bounces@lists.freedesktop.org">bounces@lists.freedesktop.org</a>] On Behalf Of Michael Teyfel > Sent: Dienstag, 17. Oktober 2017 12:02 > To: <a href="mailto:wayland-devel@lists.freedesktop.org">wayland-devel@lists.freedesktop.org</a> > Subject: [PATCH weston 00/14] Desktop Protocol Support for IVI-Shell > > Hello all, > > since some time I’m working on ivi-shell to add xdg-protocol support by > means of libweston-desktop. Due to my changes both xdg-protocol > applications and ivi-shell / ivi-application-protocol applications are supported > within ivi-shell now. The known functionality is preserved and just extended > by a further protocol. The advantage is that client applications do not need to > be edited to generate an id and are also not limited to use the custom ivi- > application protocol anymore, since the ids are handled by an id agent inside > of weston now. > > As a preparation for the changes the goto labels in ivi-shell have been > reworked to avoid memory leaks. In ivi-layout I added an interface > (ivi_layout_surface_set_id) to set the surface-id of an ivi-layout-surface. It > can be done once after being created by an xdg-protocol application to assign > a numeric id by means of an id agent for example. Additionally I introduced a > new event to notify about a desktop surface being configured > (desktop_surface_configured). An id agent can register to this event and > react to this accordingly by assigning an id by means of > ivi_layout_surface_set_id. As a result I also changed the test client > applications in the Weston repository and removed the ivi-application > protocol support since that has only been used, if xdg protocol is not > supported. Finally hmi-controller has been edited to accept desktop > surfaces. > > There are some things that can be done in the future: At first it would be > diligent, if hmi-controller would also use xdg protocol for the GUI itself. Then > also the surface_configure event could be removed from hmi-controller. > Secondly the weston unit tests should also test the interface changes for > surface_set_id and also should stop using the ivi-application protocol. > > Thanks for reading and questions are very welcome. > > > Best regards > > Michael Teyfel > Advanced Driver Information Technology GmbH > Engineering Software Base (ADITG/ESB) > Robert-Bosch-Str. 200 > 31139 Hildesheim > Germany > Tel. <a href="tel:%2B49%205121%2049%206932" value="+495121496932">+49 5121 49 6932</a> > Fax <a href="tel:%2B49%205121%2049%206999" value="+495121496999">+49 5121 49 6999</a> > <a href="mailto:mteyfel@de.adit-jv.com">mteyfel@de.adit-jv.com</a> > ADIT is a joint venture company of Robert Bosch GmbH/Robert Bosch Car > Multimedia GmbH and DENSO Corporation > Sitz: Hildesheim, Registergericht: Amtsgericht Hildesheim HRB 3438 > Geschäftsführung: Wilhelm Grabow, Ken Yaguchi > > > Michael Teyfel (14): > ivi-shell: rework goto labels to avoid memory leaks > ivi-shell: removed assert > ivi-shell: introduction of IVI_INVALID_ID > layout-interface: added interface to change surface id > ivi-layout: introduced configure_desktop_changed > ivi-layout: introduced surface create and configure > ivi-shell: linked libweston-desktop and added structs > ivi-shell: added libweston-desktop-api implementation > ivi-shell: remove surface_destroy_listener > ivi-shell: create weston_desktop in wet_shell_init > hmi-controller: register for desktop_surface_configured > simple-egl: remove ivi-application support > simple-shm: remove ivi-application support > window client: remove ivi-application support > > Makefile.am | 11 +-- > clients/simple-egl.c | 86 +++------------- > clients/simple-shm.c | 40 -------- > clients/window.c | 44 +-------- > ivi-shell/hmi-controller.c | 70 +++++++------ > ivi-shell/ivi-layout-export.h | 18 ++++ > ivi-shell/ivi-layout-private.h | 3 + > ivi-shell/ivi-layout-shell.h | 8 ++ > ivi-shell/ivi-layout.c | 142 ++++++++++++++++++++++----- > ivi-shell/ivi-shell.c | 218 > ++++++++++++++++++++++++++++++++++++++--- > ivi-shell/ivi-shell.h | 2 + > 11 files changed, 407 insertions(+), 235 deletions(-) > > -- > 2.7.4 > > _______________________________________________ > wayland-devel mailing list > <a href="mailto:wayland-devel@lists.freedesktop.org">wayland-devel@lists.freedesktop.org</a> > <a href="https://lists.freedesktop.org/mailman/listinfo/wayland-devel" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/wayland-devel</a> _______________________________________________ wayland-devel mailing list <a href="mailto:wayland-devel@lists.freedesktop.org">wayland-devel@lists.freedesktop.org</a> <a href="https://lists.freedesktop.org/mailman/listinfo/wayland-devel" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/wayland-devel</a> </div></div></blockquote></div> </div></div>