<div dir="ltr">Hi 

<span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:14px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">Emre</span><div><span style="font-size:14px"><br></span></div><div><span style="font-size:14px">I have a question about this change:<br></span>

<div><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:14px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline"><br></span></div><div><span style="font-size:14px">Is the commit_screen_list function not enough to handle the layer/surface's visibility? Why need to handle visibility in commit_changes? They are  called ivi_layout_commit_changes together.</span></div><div><span style="font-size:14px"><br></span></div><div><span style="font-size:14px">Best Regards</span></div><div><span style="font-size:14px">Nancy  </span></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">2017-02-07 21:04 GMT+08:00 Pekka Paalanen <span dir="ltr"><<a href="mailto:ppaalanen@gmail.com" target="_blank">ppaalanen@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Tue, 7 Feb 2017 12:55:59 +0000<br>
"Ucan, Emre (ADITG/SW1)" <<a href="mailto:eucan@de.adit-jv.com">eucan@de.adit-jv.com</a>> wrote:<br>
<br>
> If ivilayer or ivisurf of ivi_view is made invisible in the<br>
> commit_changes call, we have to damage the weston_view below this<br>
> ivi_view. Otherwise content of this ivi_view will stay visible.<br>
><br>
> Signed-off-by: Emre Ucan <<a href="mailto:eucan@de.adit-jv.com">eucan@de.adit-jv.com</a>><br>
> ---<br>
>  ivi-shell/ivi-layout.c |   13 ++++++++++++-<br>
>  1 file changed, 12 insertions(+), 1 deletion(-)<br>
><br>
> diff --git a/ivi-shell/ivi-layout.c b/ivi-shell/ivi-layout.c<br>
> index 712cc30..64e4ead 100644<br>
> --- a/ivi-shell/ivi-layout.c<br>
> +++ b/ivi-shell/ivi-layout.c<br>
> @@ -681,8 +681,19 @@ commit_changes(struct ivi_layout *layout)<br>
>                * If the view's layer or surface is invisible, we do not need<br>
>                * to update its properties.<br>
>                */<br>
> -             if (!ivilayer->prop.visibility || !ivisurf->prop.visibility)<br>
> +             if (!ivilayer->prop.visibility || !ivisurf->prop.visibility) {<br>
> +                     /*<br>
> +                     * If ivilayer or ivisurf of ivi_view is made invisible<br>
> +                     * in this commit_changes call, we have to damage<br>
> +                     * the weston_view below this ivi_view. Otherwise content<br>
> +                     * of this ivi_view will stay visible.<br>
> +                     */<br>
> +                     if ((ivilayer->prop.event_mask | ivisurf->prop.event_mask) &&<br>
> +                         IVI_NOTIFICATION_VISIBILITY)<br>
> +                             weston_view_damage_below(ivi_<wbr>view->view);<br>
> +<br>
>                       continue;<br>
> +             }<br>
><br>
>               update_prop(ivi_view);<br>
>       }<br>
<br>
</div></div>Hi,<br>
<br>
looks fine to me, pushed:<br>
   19222b4..7fe0bb2  master -> master<br>
<br>
<br>
Thanks,<br>
pq<br>
<br>______________________________<wbr>_________________<br>
wayland-devel mailing list<br>
<a href="mailto:wayland-devel@lists.freedesktop.org">wayland-devel@lists.<wbr>freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/wayland-devel" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/wayland-devel</a><br>
<br></blockquote></div><br></div>