<div dir="ltr">Hi Emre<div><br></div><div>I ask why calling it? which scenario could reproduce the issue you said "keep visible after set layer/surface invisible "? </div><div><br></div><div>Thank you.</div><div><br></div><div>Best Regards</div><div>Nancy</div></div><div class="gmail_extra"><br><div class="gmail_quote">2018-04-10 22:19 GMT+08:00 Ucan, Emre (ADITG/ESB) <span dir="ltr"><<a href="mailto:eucan@de.adit-jv.com" target="_blank">eucan@de.adit-jv.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div lang="EN-US" link="blue" vlink="purple"> <div class="m_7084491443666935171WordSection1"> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Hi,<u></u><u></u></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Are you asking if it is possible to move weston_view_damage_below() to commit_screen_list ? or are you asking why we are calling it ?<u></u><u></u></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p> <p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Arial","sans-serif";color:#1f497d">Best regards</span><span style="font-size:8.0pt;color:#1f497d"><br> </span><span style="font-size:8.0pt;font-family:"Arial","sans-serif";color:#1f497d"><br> </span><b><span style="font-size:10.0pt;font-family:"Arial","sans-serif";color:#1f497d">Emre Ucan</span></b><span style="font-size:8.0pt;color:#1f497d"><br> </span><span style="font-size:10.0pt;font-family:"Arial","sans-serif";color:#1f497d">Engineering Software Base (ADITG/ESB)</span><span style="font-size:8.0pt;color:#1f497d"><br> </span><span style="font-size:8.0pt;font-family:"Arial","sans-serif";color:#1f497d"><br> </span><span style="font-size:10.0pt;font-family:"Arial","sans-serif";color:#1f497d">Tel. +49 5121 49 6937</span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u><u></u></span></p> <div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt"> <div> <div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0cm 0cm 0cm"> <p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> zou lan [mailto:<a href="mailto:nancy.lan.zou@gmail.com" target="_blank">nancy.lan.zou@gmail.<wbr>com</a>] <br> <b>Sent:</b> Dienstag, 10. April 2018 08:55<br> <b>To:</b> Pekka Paalanen<br> <b>Cc:</b> Ucan, Emre (ADITG/ESB); <a href="mailto:wayland-devel@lists.freedesktop.org" target="_blank">wayland-devel@lists.<wbr>freedesktop.org</a><br> <b>Subject:</b> Re: [PATCH weston v2] ivi-shell: Damage view below after unmapping<u></u><u></u></span></p> </div> </div><div><div class="h5"> <p class="MsoNormal"><u></u> <u></u></p> <div> <p class="MsoNormal">Hi <span style="font-size:10.5pt;font-family:"Arial","sans-serif";color:#222222;background:white"> Emre</span><u></u><u></u></p> <div> <p class="MsoNormal"><u></u> <u></u></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt">I have a question about this change:</span><u></u><u></u></p> <div> <p class="MsoNormal"><u></u> <u></u></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt">Is the commit_screen_list function not enough to handle the layer/surface's visibility? Why need to handle visibility in commit_changes? They are called ivi_layout_commit_changes together.</span><u></u><u></u></p> </div> <div> <p class="MsoNormal"><u></u> <u></u></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt">Best Regards</span><u></u><u></u></p> </div> <div> <p class="MsoNormal"><span style="font-size:10.5pt">Nancy </span><u></u><u></u></p> </div> </div> </div> <div> <p class="MsoNormal"><u></u> <u></u></p> <div> <p class="MsoNormal">2017-02-07 21:04 GMT+08:00 Pekka Paalanen <<a href="mailto:ppaalanen@gmail.com" target="_blank">ppaalanen@gmail.com</a>>:<u></u><u></u></p> <div> <div> <p class="MsoNormal" style="margin-bottom:12.0pt">On Tue, 7 Feb 2017 12:55:59 +0000<br> "Ucan, Emre (ADITG/SW1)" <<a href="mailto:eucan@de.adit-jv.com" target="_blank">eucan@de.adit-jv.com</a>> wrote:<br> <br> > If ivilayer or ivisurf of ivi_view is made invisible in the<br> > commit_changes call, we have to damage the weston_view below this<br> > ivi_view. Otherwise content of this ivi_view will stay visible.<br> ><br> > Signed-off-by: Emre Ucan <<a href="mailto:eucan@de.adit-jv.com" target="_blank">eucan@de.adit-jv.com</a>><br> > ---<br> > ivi-shell/ivi-layout.c | 13 ++++++++++++-<br> > 1 file changed, 12 insertions(+), 1 deletion(-)<br> ><br> > diff --git a/ivi-shell/ivi-layout.c b/ivi-shell/ivi-layout.c<br> > index 712cc30..64e4ead 100644<br> > --- a/ivi-shell/ivi-layout.c<br> > +++ b/ivi-shell/ivi-layout.c<br> > @@ -681,8 +681,19 @@ commit_changes(struct ivi_layout *layout)<br> > * If the view's layer or surface is invisible, we do not need<br> > * to update its properties.<br> > */<br> > - if (!ivilayer->prop.visibility || !ivisurf->prop.visibility)<br> > + if (!ivilayer->prop.visibility || !ivisurf->prop.visibility) {<br> > + /*<br> > + * If ivilayer or ivisurf of ivi_view is made invisible<br> > + * in this commit_changes call, we have to damage<br> > + * the weston_view below this ivi_view. Otherwise content<br> > + * of this ivi_view will stay visible.<br> > + */<br> > + if ((ivilayer->prop.event_mask | ivisurf->prop.event_mask) &&<br> > + IVI_NOTIFICATION_VISIBILITY)<br> > + weston_view_damage_below(ivi_<wbr>view->view);<br> > +<br> > continue;<br> > + }<br> ><br> > update_prop(ivi_view);<br> > }<u></u><u></u></p> </div> </div> <p class="MsoNormal" style="margin-bottom:12.0pt">Hi,<br> <br> looks fine to me, pushed:<br> 19222b4..7fe0bb2 master -> master<br> <br> <br> Thanks,<br> pq<br> <br> ______________________________<wbr>_________________<br> wayland-devel mailing list<br> <a href="mailto:wayland-devel@lists.freedesktop.org" target="_blank">wayland-devel@lists.<wbr>freedesktop.org</a><br> <a href="https://lists.freedesktop.org/mailman/listinfo/wayland-devel" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/wayland-devel</a><u></u><u></u></p> </div> <p class="MsoNormal"><u></u> <u></u></p> </div> </div></div></div> </div> </div> </blockquote></div><br></div>