<div dir="ltr"><div>Reviewed-by: Matheus Santana <<a href="mailto:embs@cin.ufpe.br">embs@cin.ufpe.br</a>> </div>The check for negatives isn't needed anymore? </div><div class="gmail_extra"> <div class="gmail_quote">On Tue, Jun 19, 2018 at 8:44 PM, Peter Hutterer <<a href="mailto:peter.hutterer@who-t.net" target="_blank">peter.hutterer@who-t.net</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The ssize_t cast upsets coverity for some reason but we can be a lot more restrictive here anyway. Quick analysis of the zalloc calls in the test suite show the largest allocation is 9204 bytes. Let's put a cap on for one MB, anything above that is likely some memory corruption and should be caught early. Signed-off-by: Peter Hutterer <<a href="mailto:peter.hutterer@who-t.net">peter.hutterer@who-t.net</a>> --- src/libinput-util.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/libinput-util.h b/src/libinput-util.h index 8c67dcbd..4f60e8ea 100644 --- a/src/libinput-util.h +++ b/src/libinput-util.h @@ -142,7 +142,9 @@ zalloc(size_t size) { void *p; - if ((ssize_t)size < 0) + /* We never need to alloc anything even near one MB so we can assume + * if we ever get above that something's going wrong */ + if (size > 1024 * 1024) abort(); p = calloc(1, size); -- 2.17.1 _______________________________________________ wayland-devel mailing list <a href="mailto:wayland-devel@lists.freedesktop.org">wayland-devel@lists.freedesktop.org</a> <a href="https://lists.freedesktop.org/mailman/listinfo/wayland-devel" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/wayland-devel</a> </blockquote></div> </div>