<div dir="ltr">Just some style suggestions...<br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jun 22, 2018 at 10:23 AM,  <span dir="ltr"><<a href="mailto:harsha.manjulamallikarjun@in.bosch.com" target="_blank">harsha.manjulamallikarjun@in.bosch.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Harsha M M <<a href="mailto:harsha.manjulamallikarjun@in.bosch.com">harsha.manjulamallikarjun@in.<wbr>bosch.com</a>><br>
<br>
Signed-off-by: Harsha M M <<a href="mailto:harsha.manjulamallikarjun@in.bosch.com">harsha.manjulamallikarjun@in.<wbr>bosch.com</a>><br>
---<br>
 libweston/compositor.h | 12 ++++++++++++<br>
 1 file changed, 12 insertions(+)<br>
<br>
diff --git a/libweston/compositor.h b/libweston/compositor.h<br>
index c2c40ee..1e47721 100644<br>
--- a/libweston/compositor.h<br>
+++ b/libweston/compositor.h<br>
@@ -270,6 +270,18 @@ struct weston_output {<br>
                          uint16_t *g,<br>
                          uint16_t *b);<br>
<br>
+       /** set a color tranformation matrix for output<br></blockquote><div><br></div><div>According to other similar comments, I think we should capitalize the first letter ("Set").<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+        *<br>
+        * @param output_base: is the output to set tranformation for.<br>
+        * @param ctm_matrix: 4x4 matrix floating point matrix. only matrix<br></blockquote><div><br></div><div>Would "4x4 floating point matrix" (deleting the first "matrix" occurrence) be enough?<br><br></div><div>Also, maybe we should capitalize "Only".<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+        *                    member "d" of weston_matrix is relevant here.<br>
+        *<br>
+        * One of the examples of using this matrix is, for tuning the output<br>
+        * color with respect to hue saturation and brightness.<br>
+        */<br>
+       void (*set_ctm)(struct weston_output *output_base,<br>
+                       struct weston_matrix *ctm_matrix);<br>
+<br>
        struct weston_timeline_object timeline;<br>
<br>
        bool enabled; /**< is in the output_list, not pending list */<br>
<span class="HOEnZb"><font color="#888888">-- <br>
2.7.4<br>
<br>
______________________________<wbr>_________________<br>
wayland-devel mailing list<br>
<a href="mailto:wayland-devel@lists.freedesktop.org">wayland-devel@lists.<wbr>freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/wayland-devel" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/wayland-devel</a><br></font></span></blockquote><div><br><br><br></div><div>Best regards,<br></div><div>Matheus <br></div></div><br></div></div>