<div dir="ltr"><div dir="ltr">Thanks! That looks better than my patch.</div> <div class="gmail_quote"><div dir="ltr">On Mon, 17 Dec 2018 at 15:37, Alexandros Frantzis <<a href="mailto:alexandros.frantzis@collabora.com" target="_blank">alexandros.frantzis@collabora.com</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Monday, December 17, 2018 12:44 GMT, Tomek Bury <<a href="mailto:tomek.bury@gmail.com" target="_blank">tomek.bury@gmail.com</a>> wrote: > On Wed, 28 Nov 2018 at 14:35, Tomek Bury <<a href="mailto:tomek.bury@gmail.com" target="_blank">tomek.bury@gmail.com</a>> wrote: > > Hi Pekka, > > > > > I suppose the compositor-side copy of buffers you mentioned is for the > > > lack of release fences, not acquire fences? > > Yes, the lack of release fences is the very reason for the copy. I could > > cook something up for the acquire fence, but that wouldn't synchronise the > > buffer access anyway. The only way I can be sure the client doesn't > > overwrite a buffer still in use by the GPU was to texture from a copy and > > let the compositor release the original without waiting for the GPU and > > without a fence. > > > > Cheers, > > Tomek > > > Hi Pekka, Alexandros, > > Here's a patch containing all I had to do in order to test the explicit > sync support Alexandros has implemented in Weston. > > Thanks, > Tomek Hi Tomek, I have now updated the weston explicit-sync gitlab MR [1] to support, among other things, minor version 2 of the protocol. Instead of completely removing the checks, I have updated them to check for and accept all non-SHM buffers, which is adequate for current needs. There are other ways to deal with these checks if we think we need a more versatile approach (e.g., asking the renderer to tell us if it support fences for a particular buffer). Please see the MR comments for more info and discussion. Thanks, Alexandros [1] <a href="https://gitlab.freedesktop.org/wayland/weston/merge_requests/32" rel="noreferrer" target="_blank">https://gitlab.freedesktop.org/wayland/weston/merge_requests/32</a> </blockquote></div> </div>