[Xcb-commit] src

[Jeremy A. Kolb]

Have you tested this against the xvinfo demo?

On Wed, 27 Aug 2008, Julien Danjou wrote:

> src/xv.xml |    8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> New commits:
> commit 56e3160f88f30e4f08433d5da826515575b75f09
> Author: Peter Harris <peter.harris at hummingbird.com>
> Date:   Wed Aug 27 10:13:18 2008 +0200
>
>    xv.xml: Make padding explicit
>
>    I noticed that xv.xml assumes implicit padding in a couple of locations.
>    Please apply this patch to make the padding explicit. Or is implicit
>    pad support required in all consumers of xcb/proto?
>
>    Signed-off-by: Julien Danjou <julien at danjou.info>
>
> diff --git a/src/xv.xml b/src/xv.xml
> index ebf4837..e5a132f 100644
> --- a/src/xv.xml
> +++ b/src/xv.xml
> @@ -84,11 +84,12 @@ authorization from the authors.
>         <field type="CARD16" name="name_size" />
>         <field type="CARD16" name="width" />
>         <field type="CARD16" name="height" />
> -        <field type="Rational" name="rate" />
>         <!--
> -        Xvproto.h has a padding CARD16 here but the name
> -        overlaps.
> +        Some versions of Xvproto.h incorrectly have
> +        this padding after "rate".
>         -->
> +        <pad bytes="2" />
> +        <field type="Rational" name="rate" />
>         <list type="char" name="name">
>             <fieldref>name_size</fieldref>
>         </list>
> @@ -97,6 +98,7 @@ authorization from the authors.
>     <struct name="Format">
>         <field type="VISUALID" name="visual" />
>         <field type="CARD8" name="depth" />
> +        <pad bytes="3" />
>     </struct>
>
>     <struct name="Image">
> _______________________________________________
> xcb-commit mailing list
> xcb-commit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/xcb-commit
>