[Xcb-commit] icccm

Alan Coopersmith alanc at kemper.freedesktop.org
Thu Jun 24 08:04:24 PDT 2010


 icccm/icccm.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit b2c587dbd6fde31a0fdb3fa19fac94ac30a18a6f
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sun Jun 13 11:54:32 2010 -0700

    Close leak in xcb_get_text_property_reply when reply->type == XCB_NONE
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

diff --git a/icccm/icccm.c b/icccm/icccm.c
index 1c66a74..e620bde 100644
--- a/icccm/icccm.c
+++ b/icccm/icccm.c
@@ -60,8 +60,10 @@ xcb_get_text_property_reply(xcb_connection_t *c,
 {
   xcb_get_property_reply_t *reply = xcb_get_property_reply(c, cookie, e);
 
-  if(!reply || reply->type == XCB_NONE)
+  if(!reply || reply->type == XCB_NONE) {
+    free(reply);
     return 0;
+  }
 
   prop->_reply = reply;
   prop->encoding = prop->_reply->type;


More information about the xcb-commit mailing list