[Xcb-commit] libxcb: 2 commits - configure.ac src

Alan Coopersmith alanc at kemper.freedesktop.org
Tue Aug 6 11:10:33 PDT 2013


 configure.ac   |    4 ++--
 src/xcb_list.c |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 5648ddd2b97068f549268284129a438a6845e14c
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sat Aug 3 20:25:23 2013 -0700

    Define _xcb_map_new with explicit void arg list instead of empty one
    
    Fixes Solaris Studio compiler warning:
    "xcb_list.c", line 50: warning: old style function definition
    
    and gcc warning:
    xcb_list.c: In function '_xcb_map_new':
    xcb_list.c:50:11: warning: old-style function definition [-Wold-style-definition]
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
    Reviewed-by: Josh Triplett <josh at joshtriplett.org>

diff --git a/src/xcb_list.c b/src/xcb_list.c
index 6f5c611..129540b 100644
--- a/src/xcb_list.c
+++ b/src/xcb_list.c
@@ -47,7 +47,7 @@ struct _xcb_map {
 
 /* Private interface */
 
-_xcb_map *_xcb_map_new()
+_xcb_map *_xcb_map_new(void)
 {
     _xcb_map *list;
     list = malloc(sizeof(_xcb_map));
commit cb51f271b26c6abc76d415553f202bc5139273ca
Author: Alan Coopersmith <alan.coopersmith at oracle.com>
Date:   Sat Aug 3 20:22:25 2013 -0700

    Enable warnings for pre-C89 style definitions for gcc & Solaris Studio
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
    Reviewed-by: Josh Triplett <josh at joshtriplett.org>

diff --git a/configure.ac b/configure.ac
index 8cc5775..482f85b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -128,12 +128,12 @@ xcbincludedir='${includedir}/xcb'
 AC_SUBST(xcbincludedir)
 
 if  test "x$GCC" = xyes ; then
-    CWARNFLAGS="-Wall -pedantic -Wpointer-arith \
+    CWARNFLAGS="-Wall -pedantic -Wpointer-arith -Wold-style-definition \
 		-Wstrict-prototypes -Wmissing-declarations -Wnested-externs"
 else
     AC_CHECK_DECL([__SUNPRO_C], [SUNCC="yes"], [SUNCC="no"])
     if test "x$SUNCC" = "xyes"; then
-	CWARNFLAGS="-v"
+	CWARNFLAGS="-v -fd"
     fi
 fi
 AC_SUBST(CWARNFLAGS)


More information about the xcb-commit mailing list