[Xcb-commit] xcb/proto: src

[Christian Linhart]

 src/xprint.xml |   13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)

New commits:
commit 2f60597b5e1b1f927fecca3e253c694840a8e586
Author: Jaya Tiwari <tiwari.jaya18 at gmail.com>
Date:   Tue Dec 23 12:27:42 2014 -0500

    Replace valueparam with CARD32 bit field in Xprint
    
    Replaced valueparam with a simple 32 bit field for PrintSelectInput
    and PrintInputSelected by looking at the
    lib code at :
    http://cgit.freedesktop.org/xorg/lib/libXp/tree/src/XpInput.c?id=libXp-1.0.2
    
    Signed-off-by: Jaya Tiwari <tiwari.jaya18 at gmail.com>
    Reviewed-by: Christian Linhart <chris at demorecorder.com>
    
    Review-comments by Christian Linhart:
    This patch fixes a bug:
    The prior use of valueparam was incorrect, and you have fixed that bug with this patch.
    
    This can be verified by looking at the code which you have linked to.
    and by looking at the definitions of the protocol structs:
        For the PrintSelectInput-request:
            http://cgit.freedesktop.org/xorg/proto/printproto/tree/Printstr.h?id=printproto-1.0.5#n439
        For the reply of PrintInputSelected:
            http://cgit.freedesktop.org/xorg/proto/printproto/tree/Printstr.h?id=printproto-1.0.5#n457

diff --git a/src/xprint.xml b/src/xprint.xml
index e32293f..dc23dd0 100644
--- a/src/xprint.xml
+++ b/src/xprint.xml
@@ -209,21 +209,14 @@ authorization from the authors.
 
     <request name="PrintSelectInput" opcode="15">
         <field type="PCONTEXT" name="context" />
-        <valueparam value-mask-type="CARD32"
-                    value-mask-name="event_mask"
-                    value-list-name="event_list" />
+        <field type="CARD32" name="event_mask" />
     </request>
 
     <request name="PrintInputSelected" opcode="16">
         <field type="PCONTEXT" name="context" />
         <reply>
-            <pad bytes="1" />
-            <valueparam value-mask-type="CARD32"
-                            value-mask-name="event_mask"
-                            value-list-name="event_list" />
-            <valueparam value-mask-type="CARD32"
-                            value-mask-name="all_events_mask"
-                            value-list-name="all_events_list" />
+           <field type="CARD32" name="event_mask" />
+           <field type="CARD32" name="all_events_mask" />
         </reply>
     </request>