[Xcb-commit] xcb/proto: src

Peter Harris peterh at kemper.freedesktop.org
Thu Jun 2 14:32:22 UTC 2016


 src/res.xml |   10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

New commits:
commit f7948e355d85624c577d0fa63977b3bed4d6024f
Author: Peter Harris <pharris at opentext.com>
Date:   Fri May 20 19:13:34 2016 -0400

    res: Fix QueryClientIds reply size
    
    The specification disagrees with itself, so use the part of the
    specification that matches the other implementations.
    
    Reviewed-by: Ran Benita <ran234 at gmail.com>
    Signed-off-by: Peter Harris <pharris at opentext.com>

diff --git a/src/res.xml b/src/res.xml
index 17e6f83..be32ca1 100644
--- a/src/res.xml
+++ b/src/res.xml
@@ -55,7 +55,15 @@ authorization from the authors.
         <field type="ClientIdSpec" name="spec" />
         <field type="CARD32" name="length" />
         <list type="CARD32" name="value">
-            <fieldref>length</fieldref>
+            <!-- The specification says that the length is in units of CARD32,
+                 but the specification also says that the length is 4 when a
+                 single LocalClientPid is present (ie. the length is in bytes).
+                 The current server implementation sets the length to 4 when a
+                 single CARD32 is present on the wire (length is in bytes). -->
+            <op op="/">
+                <fieldref>length</fieldref>
+                <value>4</value>
+            </op>
         </list>
     </struct>
 


More information about the xcb-commit mailing list