[Xcb] unit test patch, 2

Jamey Sharp jamey at minilop.net
Thu Sep 29 12:02:31 PDT 2005

On Thu, 2005-09-29 at 06:41 -0400, Trevor Woerner wrote:
> On Thursday 29 September 2005 00:40, Barton C Massey wrote:
> > You are so polite about our hopeless falling down on the
> > job. :-)
> As it turns out the "other way" doesn't work. :-)

True enough; but it's appreciated nonetheless. :-)

> Besides, if nobody commits my code then I get to spend my Thursday 
> evening relaxing while surfing the web or reading a book... and if I 
> get particularly displeased I'll make it a non-computer book! ;-)

Golly, we can't have that. No, that would be awful.

OK, there's a couple of things in the patch that look funny on close

+       if test x$XSLTPROC != no; then

Presumably should be "xno", and if you really want to accept any value
than the variable references should be quoted.

 AC_OUTPUT([Makefile src/Makefile xcb.pc])
+if test x$HAVE_CHECK = xtrue; then
+       AC_OUTPUT(tests/Makefile)

I'm not sure you're allowed to have multiple AC_OUTPUT statements, or to
enclose AC_OUTPUT in a shell if statement. Can't you just
unconditionally output tests/Makefile? Your top-level Makefile.am seems
to be expecting it to exist anyway.

-                   -o $@ c-client.xsl $<
+                   -o $@ $(srcdir)/c-client.xsl $<

Excellent catch, but please submit this sort of thing as a separate

+#docbasedir = @DOCBASEDIR@

+#install-data-hook: CheckLog.html
+#      cp CheckLog.html $(docbasedir);

+#      $(RM) -fr $(docbasedir)

Commented out stuff shouldn't go in CVS.

Also, there's no ChangeLog entry here. I hate ChangeLogs, but we have
one, so would you please add an appropriate entry?

Otherwise, this patch looks completely unobjectionable. Would you fix
these things and re-post it?

Thanks for both your efforts and your patience. :-)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.freedesktop.org/archives/xcb/attachments/20050929/b2f529ba/attachment.pgp

More information about the Xcb mailing list