[Xcb] Re: [PATCH] DECnet support for XCB

[Jamey Sharp]

On Mon, Apr 24, 2006 at 10:54:54AM +0100, Patrick Caulfield wrote:
> Jamey Sharp wrote:
> > Would you consider producing a DECnet support patch for XCB?
> > 	http://xcb.freedesktop.org/
> > It currently makes no effort to support DECnet because I don't know
> > anyone who cares. :-) Since you apparently care, and can test such a
> > patch, I'd greatly appreciate your help.
> 
> OK, here's a code patch. I haven't done the config changes yet cos I'm
> not sure what you want/need. It requires -DDNETCONN in CFLAGS and
> -ldnet in LIBS.

Awesome -- thanks Patrick! I've committed your patch-so-far with minor
whitespace changes.

Have you had a chance to test this patch? :-) I confirmed that building
and running without DECnet support still works, but it's the usual
problem with #ifdefs... I suspect in particular that no authentication
mechanism will work, because the auth bits are protocol-specific too.

As for the configure script, at a minimum we should have a
--enable-decnet option or some such. Use AC_DEFINE for setting DNETCONN,
and we need to make sure the -ldnet is only set for libXCB and not any
of the extension libraries. I wouldn't be opposed to auto-detecting the
header and library support for DECnet if you wanted to produce such a
patch. Does that answer your question?

Thanks for your help,
--Jamey
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: Digital signature
Url : http://lists.freedesktop.org/archives/xcb/attachments/20060424/73872be9/attachment.pgp